work, responsibility
My colleague pushed broken code yesterday to one of the scripts our self service portal executes. Within like 20 minutes of making the commit a user complained that the script wasn't working for them.
I looked at the script, ran git blame, and stuff within a few minutes of them reporting the issue... It's a 2 line code change and one of the lines is invalid code. As in, a linter would catch this. The code won't even make it past this line because it has multiple syntax errors in it. Never mind code coverage, running this script at all would uncover the problem.
work, responsibility
Anyway, it's been 25 hours since the issue was reported now, in public in our slack channel. Someone else even tried to follow up and ask for help this morning.
And I could totally fix this, but I just can't get myself to do it. It just makes no sense for me to go around cleaning up after people who push broken code, don't test, and don't even react when someone points out it is broken.
I've done it too many times and it's just not worth it.
work, responsibility
Update: a third message was sent in the public channel reporting another issue with this change. My colleague has now acknowledged the issue and said he'll take a look later on. I guess it's already been broken for 2 days so no rush 
work, responsibility
@rune Feels like the more critical question here is "how did this code ever make it into a commit in the first place"...
