Honestly, I hate Regex, and I especially hate any Regex in Nixpkgs. People just shove in some random character strings with no regard for nested string escaping rules, there is no validation whatsoever, and then it is up to me to reverse engineer which flavor of Regex they meant and what the actual intent was
@piegames Wait, where are people using regex in nixpkgs? Do you mean sed commands and such?
@piegames Oof. I wonder sometimes whether people actually test the code they submit...
@joepie91 Some things I've seen were provably untested, although most are silent failures as in they capture what they need to but also silently capture too much (another reason for which I hate regex).
Anyways, these are the kind of issue to be fixed with better tooling, not by yelling at people to do better
@joepie91 exhibit 26 https://github.com/NixOS/nixpkgs/pull/403279/files
I did a treewide fixing the mess, that one is just a lone new package.
https://github.com/NixOS/nixpkgs/pull/365186
https://github.com/NixOS/nixpkgs/pull/367757